ListMailPRO Email Marketing Software Forums

ListMailPRO Email Marketing Software Forums => Development, Suggestions => Topic started by: peter on January 02, 2006, 04:55:38 am

Title: IP address sometimes incorrectly logged
Post by: peter on January 02, 2006, 04:55:38 am

I only noticed this after a server move and hence fresh logs.

LM seems to be logging the IP behind a proxy (I assume this because the logged IP is non-routeable)

PHP 5.1.1 (Fast-CGI)
Apache Logs (trimmed slightly):

Code: [Select]


203.129.242.146 - - [02/Jan/2006:16:21:32 +1000] "POST /lm/signup.php HTTP/1.0"
203.129.242.146 - - [02/Jan/2006:16:22:02 +1000] "POST /lm/signup.php HTTP/1.0"
64.78.150.119 - - [02/Jan/2006:20:33:16 +1000] "POST /lm/signup.php HTTP/1.1"

The one user that went into unconfirmed:
    Date Added: 2006-01-02  IP: 192.168.175.55

Not sure which of the above IPs is the actual one - though for this bug report probably not a problem.

Cheers,
Mathew

Title: IP address sometimes incorrectly logged
Post by: DW on January 10, 2006, 04:21:11 am

Yes, ListMail checks for the address "behind" the proxy.  This is the code in admin.php:

Code: [Select]

function getip(){
 $ipaddr = getenv("HTTP_X_FORWARDED_FOR");
 if(!$ipaddr) $ipaddr = getenv("HTTP_X_FORWARDED_FOR");
 if(!$ipaddr) $ipaddr = getenv("REMOTE_ADDR");
 if(!$ipaddr) $ipaddr = $REMOTE_ADDR;
 if(!$ipaddr){ $ipaddr = "Unknown"; }
 return $ipaddr;
}
This was implemented a while back at the request of one of my clients.  Do you think I should consider an option for turning this on or off?

Regards