broken feature

[auto]

Dean, this feature does not work:

Move users who reach end of followup sequence to list  Seq  Del

This is a problem because I really need this feature.

thanks
Tara

[DW]

Tara,

I have just re-tested v1.87 and from what I can tell the feature appears to be working.  Are you sure your dailymail task is running correctly?   Do you receive the dailymail report?

Regards,
DW

[auto]

Tara,

I have just re-tested v1.87 and from what I can tell the feature appears to be working.  Are you sure your dailymail task is running correctly?   Do you receive the dailymail report?

Regards,
DW

Yes, I am receiving the dailymail report.

Do I need to do anything special, perhaps set up something else as well to make it work?  Like auto-remove at end of sequence perhaps?

thanks
Tara

[DW]

Tara,

No, you should not need to do anything else.  I recommend re-downloading the v1.87 files and overwriting yours... if that doesn't work please submit a bug report and I will see if I can figure out what's happening.

To try some testing yourself you could try this:  change your dailymail password temporarily (so your cron task doesn't run) then uncomment this line in dailymail.php

Code: [Select]

// $DEBUG = true;
becomes:

Code: [Select]

$DEBUG = true;
Then, run dailymail manually from within ListMail for a day or three and you should be shown some information.  You might see something like this:

eos move users enabled. resetting to list 2 seq 1 del 0
123 users moved!

Regards

[auto]

Dean,

I fixed the bug.  on line #592 in 1.87 it needs to be a "while" instead of an "if", otherwise it only processes the first record and not all records.

Please make sure you update this in the main codebase so that others who may use that feature don't run into the same issue.

thanks
Tara

[BGSWebDesign]

Hi Tara,

I fixed the bug. on line #592 in 1.87 it needs to be a "while" instead of an "if",

I also need this feature, please tell me, is this the line you changed (it's a different line number for me):

Code: [Select]

   if($listopts[8]=='1'){


The code surrounding it is as follows:

Code: [Select]

   // check if moving to a new list/seq/del
    if($listopts[8]=='1'){
     $xl = $addopts[6]; $xs = $addopts[7]; $xd = $addopts[8];
     if(isset($xs) && isset($xd) && is_numeric($xs) && is_numeric($xd)){ $fs = $xs; $fd = $xd; }


[auto]

Hi Brett,

That isn't the line I updated.  I updated line #592 in the 1.87 code.  Be sure you've downloaded the lastest copy of the 1.87 code.

Hope this helps.

Tara

[BGSWebDesign]

Hi Tara,

That isn't the line I updated. I updated line #592 in the 1.87 code

PLEASE TELL US - WHICH .php file was it?

DW - you must know which one Tara is talking about, please let us know so we can ALL fix this broken feature.

[auto]

dailymail.php

[DW]

Code: [Select]

    if(@mysql_num_rows($rows)>0){
      list($fuid,$fem)=mysql_fetch_row($rows);
      // echo "<b>fuid=$fuid fem=$fem<br></b>";
      // check dupe
      $row = mysql_query("select id from $utable where list = '$xl' and email like '$fem';");
      if(@mysql_num_rows($row)>0){
       while(list($fxid)=mysql_fetch_row($row)){
        mysql_query("delete from $utable where id = '$fxid';");
       }
      }
      // update user
      mysql_query("update $utable set list = '$xl', cseq = '$xs', cdel = '$xd' where id = '$fuid';");
      if($DEBUG) echo mysql_affected_rows()." users moved!<br>";
     }
Becomes

Code: [Select]

   $moved=0;
     if(@mysql_num_rows($rows)>0){
      while(list($fuid,$fem)=mysql_fetch_row($rows)){
       $moved++;
       // check dupe
       $row = mysql_query("select id from $utable where list = '$xl' and email like '$fem';");
       if(@mysql_num_rows($row)>0){
        while(list($fxid)=mysql_fetch_row($row)){
         mysql_query("delete from $utable where id = '$fxid';");
        }
       }
       // update user
       mysql_query("update $utable set list = '$xl', cseq = '$xs', cdel = '$xd' where id = '$fuid';");
       // TODO: list add. ops
      }
      if($DEBUG) echo "$moved users moved!<br>";
     }

I'll be releasing a minor update to v1.87, probably by Monday.

Regards

[DW]

Ok an update is available.  Regards

[auto]

Thanks DW,

I'm very happy that you released this.

Tara

[BGSWebDesign]

Hi DW,

We encourage everyone affected by the bugs to upgrade to the fixed release v1.87b.

Thanks for the fix, one thing though...

I encourage you to PLEASE post which files were affected with the changes, or at least FOR the entire release, that way people like me, who have already inserted modified code (for throttling, etc), can just upload the most recent files and not EVERY PHP FILE  :shock:

I'm still not sure what you've changed, but notice I do need to upload upgrade.php and dailymail.php, as far as the other modules I don't have time to go through each one and look for changes...

Can I assume for now that if I just upload upgrade.php and dailymail.php that I'll be ok, or are there any changes in other modules that rely on changes made to dailymail.php and upgrade.php - I think you can see the dilemma here...  which could easily be solved if you listed the changes that were made to every module (and including line numbers, etc).

For example, where is this change at (module/line)?

fixed error when scheduling email to more than one user selection on the same day

For example, here's another piece of code (fix) that I've been putting BACK into your dailymail.php module since April (line 95 or around):

Code: [Select]

// BAS MOD - 04/29/06 - ADDED class=chkbox
  if($errchk) echo "<input type=checkbox class=chkbox name=nobounce value=1> Skip bounce via mailbox<br>";


[DW]

Hi Brett,

I wish I could offer "patches" but unfortunately it's beyond my experience right now.  Unfortunately it would be far too time consuming to keep track of every change on a line by line basis.

I recommend documenting your changes thoroughly so they can be re-applied when updates are released.

The database has not changed between v1.87 and v1.87b so you don't need to overwrite upgrade.php.    

as far as the other modules I don't have time to go through each one and look for changes...

Do you have access to a Linux shell via SSH?  If so, you can use the command-line utility "diff" to see changes... maybe I could use this utility to provide a report... let's see.

From a shell I had two folders ListMail_v1.87 and ListMail_v1.87b.  From the ListMail_v1.87b folder I ran:

Code: [Select]

for file in `ls -c1`; do echo $file >> out.txt; diff $file ../ListMail_v1.87/$file >> out.txt; done;
out.txt came out with:

attach/
cgi/
xtra/
mimepart.php
popup.php
rem.php
resume.php
scheduler.php
selfunc.php
sentmsgs.php
showpage.php
signup.php
smtp.php
upgrade.php
5,7c5
<
< if(!function_exists('domail')) exit(); // security to make sure admin.php was loaded
<
---
>
22c20
< $x = mysql_error(); if($x) $error = 1;
---
> $x = mysql_error(); if($x) $error = 1;
25c23
< $x = mysql_error(); if($x) $error = 1;
---
> $x = mysql_error(); if($x) $error = 1;
27c25
< $x = mysql_error(); if($x) $error = 1;
---
> $x = mysql_error(); if($x) $error = 1;
648c646
<  mysql_query("ALTER TABLE $ctable CHANGE urows sortopts TINYTEXT NOT NULL") or die('20'.mysql_error());
---
>  mysql_query("ALTER TABLE $ctable CHANGE urows sortopts TINYTEXT NOT NULL") or die('20'.mysql_error());
674c672
<
---
>
684c682
<
---
>
688c686
<
---
>
692c690
<
---
>
695c693
<
---
>
822c820
<  }
---
>  }
840c838
<
---
>
890c888
<
---
>
906c904
<  // possible msg code processing speedup
---
>  // possible msg code processing speedup
920c918
<
---
>
945c943
<
---
>
954c952
<
---
>
upload.php
Install\
and\
Upgrade.txt*
editmsg.php
editsel.php
edituser.php
777,780c777
<    if($isadupe && $isvalid){
<      if($listopts[2]=='1') remlists($email,$lis,2);
<      if($listopts[3]=='1') addlists($email,$lis,3);
<    } elseif(!$isadupe && $isvalid){
---
>     if(!$isadupe && $isvalid){
help.gif
help.php
index.php
link.php
login.php
logo.gif
mimeclass.php
dailymail.php
448d447
<     include('./selfunc.php');
457a457
>       include('./selfunc.php');
593,600c593,598
<       while(list($fuid,$fem)=mysql_fetch_row($rows)){
<        $moved++;
<        // check dupe
<        $row = mysql_query("select id from $utable where list = '$xl' and email like '$fem';");
<        if(@mysql_num_rows($row)>0){
<         while(list($fxid)=mysql_fetch_row($row)){
<          mysql_query("delete from $utable where id = '$fxid';");
<         }
---
>       list($fuid,$fem)=mysql_fetch_row($rows);
>       // check dupe
>       $row = mysql_query("select id from $utable where list = '$xl' and email like '$fem';");
>       if(@mysql_num_rows($row)>0){
>        while(list($fxid)=mysql_fetch_row($row)){
>         mysql_query("delete from $utable where id = '$fxid';");
602,604d599
<        // update user
<        mysql_query("update $utable set list = '$xl', cseq = '$xs', cdel = '$xd' where id = '$fuid';");
<        // TODO: list add. ops
606c601,603
<       if($DEBUG) echo "$moved users moved!<br>";
---
>       // update user
>       mysql_query("update $utable set list = '$xl', cseq = '$xs', cdel = '$xd' where id = '$fuid';");
>       if($DEBUG) echo mysql_affected_rows()." users moved!<br>";
domail.php
editchtml.php
editconf.php
editemsg.php
editfups.php
editlists.php
1.gif
Changes.txt
admin.php
7c7
< $file_version = '1.87b';
---
> $file_version = '1.87';
backup.php
bounce.php
config.php.txt
confirm.php
cron.php

It's going to be a bit confusing without direct comparison of the actual files but you should be able to use it to see everything changed...  First I output the filenames for each file checked.  If there are any differences you will first see a line describing the line #s.  After that, lines starting with < are new and > are old.  You can see the diff man page for more information.

fixed error when scheduling email to more than one user selection on the same day

This was fixed here:

448d447
<     include('./selfunc.php');
457a457
>       include('./selfunc.php');

The include() line was moved up, underneath "   if(@mysql_num_rows($qrows)>0){", out of the loop.

// BAS MOD - 04/29/06 - ADDED class=chkbox
  if($errchk) echo "<input type=checkbox class=chkbox name=nobounce value=1> Skip bounce via mailbox<br>";

This should no longer be necessary - I fixed it a while ago. UPDATE: Actually this was not fixed - I thought you were talking about the feature not the display of the checkbox..  I have fixed this for the next update (coming).

Regards