Email notification of bounced users broken in 1.77B

[chufford]

It appears that the email notification of a bounced user no longer works if you use a threshhold and if you have bounced users removed from the database. In 1.77b the user is removed from the database before the notification email is sent which disables the ability to send the email because the user is no longer in the database.

This happens toward the bottom of function bounce(). mysql_query("delete... is called before sendnotif().

Here is the fix that worked for me:

Code: [Select]

    if($calc <= $days){
      $lrow = mysql_query("select listopts from $ltable where listnum = '$list'");
      list($listopts)=mysql_fetch_row($lrow);
      $listopts = explode(';',$listopts);
      $narr = getnotifs($list);
      if($narr[3]=='1') sendnotif('rem_bounce',$id,'',$msg);
      if($listopts[1]==1){
       mysql_query("update $utable set cnf = '3' where id = '$id'");
      } else {
       mysql_query("delete from $utable where id = '$id'");
      }
     } else {


[davenet]

Excellent fix. I hope Dean incorporates this right away. I just was notified by a client who noticed they stopped getting notices of deleted email addresses. I'll implement this and see what happens.

David

[DW]

This could explain why some people are experiencing "vanishing" emails.  Thanks, guys.  This will definitely be fixed.

[BGSWebDesign]

Hi,

Could you please be a little more specific, I see the code in admin.php, are you removing this else:

Code: [Select]

    } else {
      $narr = getnotifs($list);
      if($narr[3]=='1') sendnotif('rem_bounce',$id,'',$msg);


So that the end code looks like this:

Code: [Select]

    if($calc <= $days){
      $lrow = mysql_query("select listopts from $ltable where listnum = '$list'");
      list($listopts)=mysql_fetch_row($lrow);
      $listopts = explode(';',$listopts);
      $narr = getnotifs($list);
      if($narr[3]=='1') sendnotif('rem_bounce',$id,'',$msg);
      if($listopts[1]==1){
       mysql_query("update $utable set cnf = '3' where id = '$id'");
      } else {
       mysql_query("delete from $utable where id = '$id'");
      }
     } else {
      $n1 = $bounces[0] . ';' . $bounces[2];
      while(list($key,$val)=each($bounces)){
       if($key > 2 ){
        $n1 .= ';' . $bounces[$key];
       }
      }
      $n1 .= ';' . $today;


Please let me know if that looks right?

[chufford]

Yes, that looks exactly like the code I have now. The change is to get and send the bounce notification before the record gets deleted. It is basically a reordering of code that was already there.

[BGSWebDesign]

Hi,

Ok, so I downloaded the latest version and went to look at the admin.php code just to make sure I had it right.  The old code is still in there???  

The code:

Code: [Select]

     $narr = getnotifs($list);
      if($narr[3]=='1') sendnotif('rem_bounce',$id,'',$msg);


still occurs AFTER the update/delete from table?   Is there something I'm missing - or did you forget to update this DW?   I know you said in another thread that the newest code was posted and corrected, but it doesn't look like it to me...  I downloaded 1.77b, unless there is somewhere newer to get the code?  

Also, I see that the changed code for signup-list1 is updated to grab the first name correctly so this must be correct code - how about a Version Code system, or some way to let us know of all the changes made - I've added my own modifications to the code and want to make the updates manually so I don't lose what I have.

There is another inconsistency I see - have a look at this:

Code: [Select]


if($narr[3]=='1') sendnotif('rem_bounce',$id,'',$msg);


and this:

Code: [Select]


      if($listopts[1]==1){


Note how one comparison is looking for =='1', while the other is ==1 is this correct DW, or should both of these be one way, or the other, or is this related to the fact that you do an explode to get one of the options, and a getnotifs($list) to get the other?

Also, I don't like to keep asking this but WHEN are we going to see the update and the new version DW?

Let me know, as I want to make sure I have this right - messing with the Bounce Code needs to be correct.

[DW]

I have simply replaced the existing v1.77b ZIP with a new one.

This code WAS incorrect (I just downloaded and viewed the file).

The fix needed to be applied in TWO places but I only did it in one.  The file available NOW works.

I see the mistake with the quotes - it shouldn't matter but it is an inconsistency.

The version will be shown more clearly in the next update.  Currently, the program only changes version numbers when a database update must take place.

Please be patient.  I'm working on the update almost every day.

Regards

[BGSWebDesign]

Hi Dean,

The fix needed to be applied in TWO places but I only did it in one.  The file available NOW works.

Ok, where is the second place the code changes?  I'll have to locate that and make the change as well....   please let me know there's many lines of code here, I don't see any more of the sendnotif calls?

Code: [Select]


      $narr = getnotifs($list);
      if($narr[3]=='1') sendnotif('rem_bounce',$id,'',$msg);


Please be patient.  I'm working on the update almost every day.

Great, just looking forward to it!!!  With all the changes talked about it should really move my sending forward    any idea at all on how much longer?