Extra ! being sent out. Caused a PRICING problem.

[boundless]

Three more questions:

1. Are the codes having problems actually nested inside a code of the type 'Custom Text' or are they just on their own?

No, they are outside any custom text, ie "Hi, !fname" at the beginning of the message, or "!fname, here's a new resource" in the subject line (without the quotes of course)

2. Does the !fname code exist in more than one place?  (e.g. Global AND List 1)

No.

3. Are you sending text-only or text+HTML?

Text-only.

[DW]

Thanks for your input Trevor - it does seem very strange and I still can't seem to recreate the issue - it must be server specific.

The message code processing is the same for all messages - so the issue shouldn't only appear in dailymail.  That is, unless something in dailymail is getting in the way.

If the code !name is being replaced, without the ! then the only explanation is that this line (563, admin.php), which retrieves the "!" (keycode / $keych) from the config table is failing:

Code: [Select]

list($linkch,$keych,$lmpath,$ktr)=mysql_fetch_row(mysql_query("select linkcode,keycode,listmailpath,ktrack from $ctable where 1",$link));
For a manual fix, Bob, add a new line just under that one:

Code: [Select]

$keych = '!';
Regards

[boundless]

If the code !name is being replaced, without the ! then the only explanation is that this line (563, admin.php), which retrieves the "!" (keycode / $keych) from the config table is failing:

Code: [Select]

list($linkch,$keych,$lmpath,$ktr)=mysql_fetch_row(mysql_query("select linkcode,keycode,listmailpath,ktrack from $ctable where 1",$link));

My admin.php file from my 1.8 update archive does not have this code at line 563.

It has this:

Code: [Select]

while(list($k,$v)=each($inarr)){
  if($v){
   $xmsg = $v;
   if($k==2) $mhtml = 1; else $mhtml = 0;

   if(!$pre){
    // get list title
    $cmd = "select title from $ltable where listnum = '$lnum'";
    $lrow = @mysql_query($cmd,$link);
    if($sqldebug) echo "CMD=<b>$cmd</b><br>";
    list($ltitle)=@mysql_fetch_row($lrow);
   } else $ltitle = 'Preview List';

[mr.trevor]

My system shows that line at 541. I have the same as Bob for 563.
Have there been any updates I have missed since the 'final 1.8 release'?

[boundless]

My system shows that line at 541. I have the same as Bob for 563.
Have there been any updates I have missed since the 'final 1.8 release'?

And just to clarify, I downloaded the file again this morning so I know I'm looking at the lastest.

Bob

[DW]

Sorry about that, I'm using work-in-progress files.  As long as you add the line I mentioned after the other line I mentioned you should be ok.  If you still see "!" before the name after the code has processed then I would say you might have included the extra "!" accidentally, ie:  !!fname

Regards

[boundless]

Sorry about that, I'm using work-in-progress files.  As long as you add the line I mentioned after the other line I mentioned you should be ok.  If you still see "!" before the name after the code has processed then I would say you might have included the extra "!" accidentally, ie:  !!fname

Well of course, I know that's not the case because these are the same follow-ups I've been using for 3 years without a problem... plus, I did go check just as a super-safety measure, but I knew that wasn't it.

Bob

[boundless]

Sorry about that, I'm using work-in-progress files.  As long as you add the line I mentioned after the other line I mentioned you should be ok.  If you still see "!" before the name after the code has processed then I would say you might have included the extra "!" accidentally, ie:  !!fname

Regards

Well the code change you gave me worked for the dailymail, but the Scheduled mail I sent out still has the extra "!". Where might I add the code to prevent that from happening in scheduled mail?

And I don't know if this tells you anything, but the mailing stopped several times (very common with my larger mailings by the way), and it SEEMS that the mail that was sent out when I "resume" does NOT give the extra "!"... ??

Bob


Bob

[DW]

Bob,

I'm sorry to hear you're still having troubles - this is really strange.  I might need access to your server to figure it out as I can't seem to recreate the error on my own installation.  (Please be assured I would never touch anything unrelated to this issue)  It would be handy if you could also give me instructions on how to recreate the error on a test list, though, I can probably figure it out based on what you have written here.

Regards

[boundless]

Bob,

I'm sorry to hear you're still having troubles - this is really strange.  I might need access to your server to figure it out as I can't seem to recreate the error on my own installation.  (Please be assured I would never touch anything unrelated to this issue)  It would be handy if you could also give me instructions on how to recreate the error on a test list, though, I can probably figure it out based on what you have written here.

Regards

Yeah, and to make it even more confusing, some of the dailymail that is being sent is STILL adding the !, while other mail is not. Bizarre....

[boundless]

Despite the changes to the code, SOME people are still receiving email with the extra "!". BUT WORSE, just as the word "price" in the email was being replaced with what was the !price variable, now the word "email" is being replace with what would show with "!email" which resulted in a VERY angry person accusing me of sharing her email address with everyone on my list because it appeared in the email that obviously went to everyone!

Dean, while I'm hesitant to upload all my access information to you, I'm finding that I have no choice because this simply can't happen anymore, and it doesn't appear that I can go "backward" in my installation at this point.

On the form that you gave me to submit, what exactly is "Control Panel". Are you talking about the control panel for the entire site that my web host provides? I'm not clear why you would need anything more than my FTP and Listmail Pro directory and access information.

In any case, tell me exactly what you need, and let's get this fixed today. This is clearly affecting the relationship with my customers that I work so hard to create using this very same software!

Bob

[boundless]

What does the database know/care about the directory from which signup scripts are run, and would where they signup have ANYTHING to do with this issue?

For example, many of these people are signed up via email automatically upon enrolling in our program through your script.

The signup.php script for those who actually filled out forms has always been run from a different directory than the actual listmail pro installation...that is I had a copy of signup.php and admin.php in the directory where the form HTML was. (I don't remember exactly why I did this, and as of this morning, I'm pointing those forms back to the code in the installation directory...)

In other words...

IF I were to create an entirely NEW installation with a NEW database, and put all the code into a "mail" directory (right now it's called something else), then EXPORT my existing database, then IMPORT it into the new database, would everything still work - or work properly, that is...

Bob

[boundless]

Ok, this could be the ah-ha/breakthrough that answers it.

The CRON JOB!!

When I first set up this software 3 years ago, I sent the cron job instructions to my host admin. Those instructions were pointing to an OLD installation of the program...a listmail directory I haven't "used" in forever, but the code was still there!

Perhaps THAT is what's causing the problem? Running old code on daily mail and scheduled mail? It had just been so long that it didn't occur to me until this morning to check the cron job instructions!

Man, if this is it, a BIG flick in the head goes to me!  :lol:

Bob

[DW]

Bob,

On the form that you gave me to submit, what exactly is "Control Panel". Are you talking about the control panel for the entire site that my web host provides? I'm not clear why you would need anything more than my FTP and Listmail Pro directory and access information.

The control panel is where you manage your hosting account.  From here you can set up email accounts, (possibly) MySQL databases, and other aspects of your hosting.

What does the database know/care about the directory from which signup scripts are run, and would where they signup have ANYTHING to do with this issue?

For example, many of these people are signed up via email automatically upon enrolling in our program through your script.

The signup.php script for those who actually filled out forms has always been run from a different directory than the actual listmail pro installation...that is I had a copy of signup.php and admin.php in the directory where the form HTML was. (I don't remember exactly why I did this, and as of this morning, I'm pointing those forms back to the code in the installation directory...)

The database and the directory are fairly independent - they're tied together in config.php, where you set up your database details.  As long as the signup.php script exists in any directory it can subscribe users into the database configured.

Providing the user information appears correct in ListMail, it should not be a signup issue.

IF I were to create an entirely NEW installation with a NEW database, and put all the code into a "mail" directory (right now it's called something else), then EXPORT my existing database, then IMPORT it into the new database, would everything still work - or work properly, that is...

You could do this but you would lose some data as not all fields are currently supported by the Import/Export processes.  I don't suspect it's a problem with your user data, the directory, or database ListMail is installed on.

When I first set up this software 3 years ago, I sent the cron job instructions to my host admin. Those instructions were pointing to an OLD installation of the program...a listmail directory I haven't "used" in forever, but the code was still there!

Perhaps THAT is what's causing the problem? Running old code on daily mail and scheduled mail? It had just been so long that it didn't occur to me until this morning to check the cron job instructions!

I am not sure if this is the problem.  All of your email is being sent from the new host, correct?  It should not matter which host you run the cron task on - you could run the task on an old server to point to a new server.  Problems can arise if you are running 2 cron jobs on the same installation, however.

Since you mentioned running old signup scripts, I wonder if your files are all up-to-date.  Can you please re-download v1.8 and upload all files in the main directory and make sure to overwrite all of them?

Another idea I have is that you may be Resuming too soon.  When the page "times out" and you think there's an error, try going back into the ListMail program and browsing around.  You will see a queue entry at the top of the program listing the number of remaining messages.  Refresh the page or browse to another one to have it update the number of remaining messages.  If this number is still decreasing you should not yet Resume mailing.  I will be implementing a check for this.  Perhaps when mailing it will update the database every 1 minute or so to tell ListMail that it's still running.  ListMail could then prevent you from resuming queues that have responded within 1 minute.  I am not certain that this can affect message codes in the manner you are experiencing, but it's an idea.

Regards