Unconfirmed cannot re-signup

[suren]

Hi Dean,

I just upgraded to v1.85 and noticed that if a user has signed up but is unconfirmed, he cannot signup again through the web form. When he tries, he gets "email already exists" message.

Is this by design? I am pretty sure that v1.84 allowed an unconfirmed user to signup again.

Regards,
Suren

[DW]

Yes, this would appear to be by design and I can't recall why I changed this.  I don't mind updating it again.

Line 91 of signup.php

Code: [Select]

  $cmd = "select id,uid,cnf from $utable where list = '$list' and email like '$email'";
to only check Active users for duplicates, it should be:

Code: [Select]

  $cmd = "select id,uid,cnf from $utable where list = '$list' and email like '$email' and cnf = '1'";
I've enabled this now in my new (v1.86) files and will update the v1.85 download.

As well as overwriting unconfirmed users, do you think we should overwrite removed users, or make it an option?  I could create a separate error message for removed users, ie. "You were previously removed from this list and may not resubscribe." to clear up confusion when a signup is refused.  Bounced users should always be allowed to re-subscribe.

Regards

[suren]

Oh, thanks for that. I will make that code change on the signup.php.

Personally, I prefer to allow re-signup for unconfirmed users but not for removed users. I think a different error message for removed users is a great idea. An option to allow removed users to re-signup is also great.

Thanks Dean